Fix coord_categorisation.add_weekday#4139
Merged
trexfeathers merged 2 commits intoSciTools:auto-update-lockfilesfrom May 17, 2021
Merged
Fix coord_categorisation.add_weekday#4139trexfeathers merged 2 commits intoSciTools:auto-update-lockfilesfrom
trexfeathers merged 2 commits intoSciTools:auto-update-lockfilesfrom
Conversation
trexfeathers
approved these changes
May 17, 2021
Contributor
trexfeathers
left a comment
trexfeathers
left a comment
There was a problem hiding this comment.
Thanks @rcomer!
While there are many other uses of num2date(), they all appear to be happily working with the new default return of cftime.datetime already, so no need to add the same argument to all those calls too.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
Description
See #4137
Explicitly make the
coord_categorisationfunctions always use acftime.datetimeinstance, so that tests pass withcf_unitsv2.1.5. I also removed the comment aboutUnit.num2datebeing deprecated. That comment dated back to the days whenUnitwas part of Iris, and I can't see anything incf_units.__init__.pyto suggestUnit.num2dateis deprecated.I also fixed a link to the
blackdocs. This duplicates part of #4132, but it looks like the main tests in that PR can't pass without pulling in this change anyway.I am on leave for the next week but happy if someone else applies any changes here if they are needed in the meantime.
Consult Iris pull request check list